Re: cdp buffer overflow vulnerability

[Vade 79]

In-Reply-To: <20040331161611.75451.qmail@web25104.mail.ukl.yahoo .com>

for the patch you provided you should use sizeof(buffer), not strlen(buffer) (or 200) to limit the amount written to buffer[].

>--- songname.patch ---
>
>--- cdp.c 2004-03-31 15:48:55.000000000 +0100
>+++ cdp.1.c 2004-03-31 15:44:35.000000000 +0100
>@@ -154,7 +154,7 @@
> for ( ind = 0; ind < cdStatus.thiscd.ntracks;
>ind++ ) {
> trk = &cdStatus.thiscd.trk[ ind ];
> if ( trk->songname != NULL ) {
>- sprintf( buffer, "%s", trk->songname );
>+ snprintf( buffer, strlen(buffer), "%s",
>trk->songname );
> } else
> buffer[ 0 ] = 0;
>
>
>--- eof ---

[Dave Paris]

I would respectfully recommend submitting a more descriptive subject line
next time. I saw "cdp" and the first thing that came to mind was "Cisco
Discovery Protocol".

Kind Regards,
-dsp

> -----Original Message-----
> From: Shaun Colley [mailto:shaunige@yahoo.co.uk]
> Sent: Wednesday, March 31, 2004 11:16 AM
> To: bugtraq@securityfocus.com
> Subject: cdp buffer overflow vulnerability
>
>
> ~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~* ~*~*~*
>
> Product: cdp - console cd player
[...]